-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DesignTools] makeBlackbox() to use phys netlist not logical #1044
base: master
Are you sure you want to change the base?
Conversation
Since EDIFNetlist may be partially encrypted Also speedup/cleanup. Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible to construct a scenario where two sibling encrypted cells could have the same prefix, but due to the wide allowance in naming conventions, could in fact be different. I'm not sure how often in practice this would occur, but IP generated from the tools seems to trigger this case.
I think if we can prove this approach works for the variety of tests and scenarios we have been looking at, I am inclined to move this direction.
I've been trying to think of an example of this, but struggling to. I know that the logical netlist may have hierarchical names where If you've got an example handy please send it my way! |
Suppose you want to black box the instance |
I think I'm following. Consider two groups of leaf cells, each under a legitimate logical hierarchy:
Now these logical leaf cells lead to unique physical cell names. But I wonder what happens if the cell names collide? (i.e. |
Currently,
makeBlackbox()
leverages theEDIFNetlist
to find all leaf cells inside a particular point of the hierarchy. In the case of encrypted or detached netlists, this is not possible. Instead, this PR proposes that only the physical netlist is used by assuming that anyCell
that starts with the hierarchical name must be within the hierarchy to be blackboxed.Am I missing a reason why this shouldn't be done? The only reason I can think of is that simply relying on the
Cell
name prefix may be imprecise, but is that enough of a (rare) reason to not proceed?This PR also: